-
Notifications
You must be signed in to change notification settings - Fork 15.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix javadoc warnings in generated files #6231
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generally looks good to me. Thank you for doing this! Would you be willing to follow up with more changes to update the remaining WriteFieldDocComment?
That's the plan. It might take some time, though, as I currently have only limited free time. |
Progress: 255/450 (55%) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking very good. Let's hold at this state for now. I want to make sure this can successfully get in (the larger the PR, the harder it is to get in).
Currently it is too hot to concentrate properly. I'll wait with the fixes until it gets a little bit colder. |
I have fixed the above mentioned issues. |
This looks good. Thank you for improving protobuf! |
Fix javadoc warnings in generated files
Currently the protoc generated java classes will cause javadoc compilation warnings due to missing
@param
and@return
values.I first thought this was an easy change, but I soon discovered that this takes quite some effort.
That's why I would like to get some feedback whether these changes have a chance to be merged at all / are appreciated.
This PR is by no means complete, I just changed about 50/430 occurances of
WriteFieldDocComment
.