fix a UBSAN warnings. #6333
Merged
fix a UBSAN warnings. #6333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Asra Ali <asraa@google.com>
|
Thanks, @asraa. |
htuch
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Jul 10, 2019
In addition to updating protobuf to 3.8.0, this PR also Removes old protobuf patch now included in 3.8.0 - Patches protocolbuffers/protobuf#6333 that fixes a UBSAN error in the protobuf library. - Patches protobuf's BUILD to depend on foreign_cc zlib Risk level: low/medium Testing: bazel test //test/... Signed-off-by: Asra Ali <asraa@google.com>
mattklein123
pushed a commit
to envoyproxy/data-plane-api
that referenced
this pull request
Jul 10, 2019
In addition to updating protobuf to 3.8.0, this PR also Removes old protobuf patch now included in 3.8.0 - Patches protocolbuffers/protobuf#6333 that fixes a UBSAN error in the protobuf library. - Patches protobuf's BUILD to depend on foreign_cc zlib Risk level: low/medium Testing: bazel test //test/... Signed-off-by: Asra Ali <asraa@google.com> Mirrored from https://github.com/envoyproxy/envoy @ 8246167b9d238797cbc6c03dccc9e3921c37617d
lizan
pushed a commit
to envoyproxy/envoy
that referenced
this pull request
Sep 27, 2019
Adds back protobuf patch fixing UBSAN error (protocolbuffers/protobuf#6333). This was removed on updating protobuf to 3.9.1, but will be included in the protobuf 3.10 release. Fixes OSS-Fuzz issue: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=17759 Testing: Added corpus Signed-off-by: Asra Ali <asraa@google.com>
danzh2010
pushed a commit
to danzh2010/envoy
that referenced
this pull request
Oct 4, 2019
Adds back protobuf patch fixing UBSAN error (protocolbuffers/protobuf#6333). This was removed on updating protobuf to 3.9.1, but will be included in the protobuf 3.10 release. Fixes OSS-Fuzz issue: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=17759 Testing: Added corpus Signed-off-by: Asra Ali <asraa@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a UBSAN error reproduced from an OSS-Fuzz testcase
Similar to #5901 for 32-bit integers.
Signed-off-by: Asra Ali asraa@google.com