Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE: KC: Suppress unavailable connects #4061

Merged
merged 5 commits into from
Aug 1, 2023

Conversation

iliax
Copy link
Contributor

@iliax iliax commented Jul 25, 2023

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

  1. suppressing connect errors when returning list of all connectors
  2. minor refactoring of KafkaConnectService.getAllConnectors

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@iliax iliax requested a review from a team as a code owner July 25, 2023 10:35
@github-actions github-actions bot added the status/triage Issues pending maintainers triage label Jul 25, 2023
@iliax iliax linked an issue Jul 25, 2023 that may be closed by this pull request
4 tasks
@iliax iliax enabled auto-merge (squash) July 25, 2023 10:40
@Haarolean Haarolean added type/bug Something isn't working scope/backend and removed status/triage Issues pending maintainers triage labels Aug 1, 2023
@Haarolean Haarolean changed the title Unavailable connects suppressing BE: KC: Suppress unavailable connects Aug 1, 2023
@iliax iliax merged commit 895d27a into master Aug 1, 2023
11 checks passed
@iliax iliax deleted the ISSUE-3977_unavailable_connect_fix branch August 1, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/backend type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connectors page breaks when one connect cluster unavailable
2 participants