Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taztingo/1414 update wasmd gov tx #1461

Merged
merged 3 commits into from
Apr 5, 2023
Merged

Conversation

Taztingo
Copy link
Contributor

@Taztingo Taztingo commented Apr 5, 2023

Description

This PR updates our wasmd dependency, and modifies app.go to include the auth address for the WasmKeeper. SDK46 altered the path of proposals, and they now go through the same path as normal transactions. These shared paths needed to be updated within the wasmd module to check if the sender was the gov module or a normal user, and then apply the correct policy. These changes were a manual insertion of work done by Cosmwasm's 1269.

closes: #1414


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@Taztingo Taztingo requested a review from a team as a code owner April 5, 2023 18:44
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #1461 (f9772c1) into main (99e9ecf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1461   +/-   ##
=======================================
  Coverage   59.96%   59.96%           
=======================================
  Files         196      196           
  Lines       24590    24591    +1     
=======================================
+ Hits        14746    14747    +1     
  Misses       8728     8728           
  Partials     1116     1116           
Impacted Files Coverage Δ
app/app.go 82.98% <100.00%> (+0.02%) ⬆️

@iramiller
Copy link
Member

Changes being pulled in with this update can be review here: provenance-io/wasmd@v0.30.0-pio-1-rc3...v0.30.0-pio-2-rc2

@Taztingo Taztingo merged commit c558355 into main Apr 5, 2023
@Taztingo Taztingo deleted the taztingo/1414-update-wasmd-gov-tx branch April 5, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wasm storage via new gov proposal functionality not supported
5 participants