Remove name legacy governance proposal #1963
Conversation
WalkthroughThe recent update involves the removal of legacy government proposals related to Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Taztingo
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (1)
CHANGELOG.md (1)
Line range hint
77-321: Consistent list item markers should be used.- - Bump cosmos-SDK to `v0.50.2` (from `v0.46.13-pio-2`) [#1772](https://github.com/provenance-io/provenance/issues/1772). + * Bump cosmos-SDK to `v0.50.2` (from `v0.46.13-pio-2`) [#1772](https://github.com/provenance-io/provenance/issues/1772). - - Add store for crisis module for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Add store for crisis module for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760). - - Add PreBlocker support for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Add PreBlocker support for sdk v0.50 [#1760](https://github.com/provenance-io/provenance/issues/1760). - - Add the Sanction module back in [#1922](https://github.com/provenance-io/provenance/pull/1922). + * Add the Sanction module back in [#1922](https://github.com/provenance-io/provenance/pull/1922). - - Add the Quarantine module back in [#1926](https://github.com/provenance-io/provenance/pull/1926). + * Add the Quarantine module back in [#1926](https://github.com/provenance-io/provenance/pull/1926). - - Bump wasmd to `v0.50.0` [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Bump wasmd to `v0.50.0` [#1760](https://github.com/provenance-io/provenance/issues/1760). - - Remove unsupported database types [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Remove unsupported database types [#1760](https://github.com/provenance-io/provenance/issues/1760). - - Update ibc and migrate params [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Update ibc and migrate params [#1760](https://github.com/provenance-io/provenance/issues/1760). - - Replace ModuleBasics with BasicModuleManager [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Replace ModuleBasics with BasicModuleManager [#1760](https://github.com/provenance-io/provenance/issues/1760). - - Remove handlers from provenance modules [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Remove handlers from provenance modules [#1760](https://github.com/provenance-io/provenance/issues/1760). - - Updated app.go to use RegisterStreamingServices on BaseApp [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Updated app.go to use RegisterStreamingServices on BaseApp [#1760](https://github.com/provenance-io/provenance/issues/1760). - - Bump the SDK to `v0.50.5-pio-1` (from an earlier ephemeral version) [#1897](https://github.com/provenance-io/provenance/pull/1897). + * Bump the SDK to `v0.50.5-pio-1` (from an earlier ephemeral version) [#1897](https://github.com/provenance-io/provenance/pull/1897). - - Removed `rewards` module [#1905](https://github.com/provenance-io/provenance/pull/1905). + * Removed `rewards` module [#1905](https://github.com/provenance-io/provenance/pull/1905). - - Remove unused navs [#1920](https://github.com/provenance-io/provenance/issues/1920). + * Remove unused navs [#1920](https://github.com/provenance-io/provenance/issues/1920). - - Remove emitting of EventTypeMessage [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Remove emitting of EventTypeMessage [#1760](https://github.com/provenance-io/provenance/issues/1760). - - Update genutil for sdk 50 [#1760](https://github.com/provenance-io/provenance/issues/1760). + * Update genutil for sdk 50 [#1760](https://github.com/provenance-io/provenance/issues/1760). - - Migrate module params from param space to module store.[#1760](https://github.com/provenance-io/provenance/issues/1935) + * Migrate module params from param space to module store.[#1760](https://github.com/provenance-io/provenance/issues/1935) - * Attribute module param migration [#1927](https://github.com/provenance-io/provenance/pull/1927). + * Attribute module param migration [#1927](https://github.com/provenance-io/provenance/pull/1927). - * Marker module param migration [#1934](https://github.com/provenance-io/provenance/pull/1934). + * Marker module param migration [#1934](https://github.com/provenance-io/provenance/pull/1934). - * Metadata module param migration [#1932](https://github.com/provenance-io/provenance/pull/1932). + * Metadata module param migration [#1932](https://github.com/provenance-io/provenance/pull/1932). - * Msgfees module param migration [#1936](https://github.com/provenance-io/provenance/pull/1936). + * Msgfees module param migration [#1936](https://github.com/provenance-io/provenance/pull/1936). - * Name module param migration [#1937](https://github.com/provenance-io/provenance/pull/1937). + * Name module param migration [#1937](https://github.com/provenance-io/provenance/pull/1937). - * IbcHooks module param migration [#1939](https://github.com/provenance-io/provenance/pull/1939). + * IbcHooks module param migration [#1939](https://github.com/provenance-io/provenance/pull/1939). - - Restore the hold module [#1930](https://github.com/provenance-io/provenance/pull/1930). + * Restore the hold module [#1930](https://github.com/provenance-io/provenance/pull/1930). - - Restore gov-prop cli commands and fix next key decoding [#1930](https://github.com/provenance-io/provenance/pull/1930). + * Restore gov-prop cli commands and fix next key decoding [#1930](https://github.com/provenance-io/provenance/pull/1930). - - Switch to InputOutputCoinsProv for exchange transfers [#1930](https://github.com/provenance-io/provenance/pull/1930). + * Switch to InputOutputCoinsProv for exchange transfers [#1930](https://github.com/provenance-io/provenance/pull/1930). - - Use fields of the SimulationState for the encoders needed for simulations [#1931](https://github.com/provenance-io/provenance/pull/1931). + * Use fields of the SimulationState for the encoders needed for simulations [#1931](https://github.com/provenance-io/provenance/pull/1931). - - Fix most of the failing unit tests [#1943](https://github.com/provenance-io/provenance/pull/1943) + * Fix most of the failing unit tests [#1943](https://github.com/provenance-io/provenance/pull/1943) - - Remove `name` legacy gov proposals [#1953](https://github.com/provenance-io/provenance/pull/1953). + * Remove `name` legacy gov proposals [#1953](https://github.com/provenance-io/provenance/pull/1953).
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (4)
CHANGELOG.md (4)
Line range hint
784-784: Remove extra blank line.-There are multiple consecutive blank lines, which should be reduced to a single blank line for better readability and consistency.
Line range hint
195-195: Convert bare URL to a markdown link.- https://github.com/provenance-io/provenance/issues/105 + [Issue #105](https://github.com/provenance-io/provenance/issues/105)For better readability and to follow markdown best practices, convert bare URLs to markdown links.
Line range hint
912-912: Remove spaces inside emphasis markers.- * Provenance * + *Provenance*Spaces inside emphasis markers can lead to rendering issues. It's best to remove them to ensure the text is emphasized correctly.
Line range hint
308-308: Remove spaces inside code span elements.- ` provenance ` + `provenance`Spaces inside code span elements can lead to unexpected formatting. It's best to remove them to ensure the code is highlighted correctly.
…ove simulation for proposals.
There was a problem hiding this comment.
Actionable comments posted: 3
Out of diff range and nitpick comments (1)
x/name/types/codec.go (1)
[!TIP]
Codebase VerificationSeveral files in the codebase still reference the supposedly removed
MsgCreateRootNameRequest. This suggests that the removal was not fully implemented. Here are the files that need attention:
x/name/types/msgs.gox/name/types/codec.goAnalysis chain
Line range hint
9-17: Ensure that the removed message types are no longer referenced anywhere in the codebase.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that removed message types are not referenced in the codebase. # Search for references to the removed message types. rg --files-with-matches --type go 'MsgCreateRootNameRequest' | while read file; do # Test: Search for the removed message type to find omissions. Expect: No matches. ast-grep --lang go --pattern $'&MsgCreateRootNameRequest{}' "$file" doneLength of output: 970
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (8)
CHANGELOG.md (8)
Line range hint
77-321: Convert unordered list markers from dashes to asterisks for consistency.- - + *
Line range hint
785-785: Remove consecutive blank lines to maintain a clean and consistent format.-
Line range hint
1186-1186: Remove consecutive blank lines to maintain a clean and consistent format.-
Line range hint
1203-1203: Remove consecutive blank lines to maintain a clean and consistent format.-
Line range hint
1255-1255: Remove consecutive blank lines to maintain a clean and consistent format.-
Line range hint
1359-1359: Remove consecutive blank lines to maintain a clean and consistent format.-
Line range hint
913-913: Remove spaces inside emphasis markers to ensure proper Markdown rendering.- * message * + *message*
Line range hint
309-309: Remove spaces inside code span elements to ensure proper Markdown rendering.- ` message ` + `message`
There was a problem hiding this comment.
Actionable comments posted: 1
Out of diff range and nitpick comments (1)
x/name/spec/03_messages.md (1)
90-90: Clarify the deprecation message forCreateRootNameProposal.Consider rephrasing to "This legacy proposal has been deprecated in favor of the message-based governance proposals, such as
MsgCreateRootNameRequest."
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
x/name/types/name.pb.gois excluded by!**/*.pb.go
Files selected for processing (3)
- proto/provenance/name/v1/name.proto (1 hunks)
- x/name/module.go (1 hunks)
- x/name/spec/03_messages.md (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- proto/provenance/name/v1/name.proto
Additional Context Used
LanguageTool (5)
x/name/spec/03_messages.md (5)
Near line 3: It appears that a comma is missing.
Context: # Messages In this section we describe the processing of the staki...
Near line 85: Possible missing comma found.
Context: ...h the gov module or the name owner. If successful a name record will be updated with the ...
Near line 89: The word ‘create’ is a verb. Did you mean the noun “creation”?
Context: ...iction. ## CreateRootNameProposal The create root name proposal is a governance prop...
Near line 90: This expression is usually spelled with a hyphen.
Context: ...gacy proposal is deprecated in favor of message based gov proposals, see MsgCreateRootNameReq...
Near line 132: Possible missing comma found.
Context: ...rity does not match the gov module. If successful a name record will be created with the ...
There was a problem hiding this comment.
Actionable comments posted: 1
Out of diff range and nitpick comments (4)
x/name/spec/03_messages.md (4)
Line range hint
131-131: Consider adding a comma after "module" for better readability.
Line range hint
3-10: Update the Table of Contents to remove the deprecatedCreateRootNameProposalsection.
Line range hint
6-10: Correct the indentation for list items in the Table of Contents to ensure consistency.
Line range hint
37-37: Ensure headings are surrounded by blank lines for proper markdown formatting.
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- x/name/spec/03_messages.md (1 hunks)
Additional Context Used
LanguageTool (6)
x/name/spec/03_messages.md (6)
Near line 3: It appears that a comma is missing.
Context: # Messages In this section we describe the processing of the staki...
Near line 36: A comma might be missing here.
Context: ...arent record (targets another root) If successful a name record will be created as descri...
Near line 84: Possible missing comma found.
Context: ...h the gov module or the name owner. If successful a name record will be updated with the ...
Near line 88: The word ‘create’ is a verb. Did you mean the noun “creation”?
Context: ...iction. ## CreateRootNameProposal The create root name proposal is a governance prop...
Near line 89: This expression is usually spelled with a hyphen.
Context: ...gacy proposal is deprecated in favor of message based gov proposals, see MsgCreateRootNameReq...
Near line 131: A comma might be missing here.
Context: ...rity does not match the gov module. If successful a name record will be created with the ...
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- app/app.go (4 hunks)
- x/name/client/cli/cli_test.go (3 hunks)
- x/name/client/cli/tx.go (4 hunks)
Files skipped from review as they are similar to previous changes (1)
- app/app.go
Additional comments not posted (3)
x/name/client/cli/tx.go (2)
46-46: The addition ofGetGovRootNameCmd()to the command list inNewTxCmd()aligns with the PR's objective to streamline governance mechanisms by introducing direct management commands for root names.
171-216: The newGetGovRootNameCmd()function introduces a governance proposal command for creating root names. This change is consistent with the PR's objective to replace the old proposal system with more direct commands. However, ensure that the command's flags and parameters are thoroughly documented in the user guide to avoid confusion.x/name/client/cli/cli_test.go (1)
Line range hint
576-711: The new testTestGovRootNameCmd()effectively checks the functionality of theGetGovRootNameCmd()command. It includes various scenarios, such as successful creation, failure due to missing arguments, and invalid input handling. This comprehensive testing approach is crucial for ensuring the robustness of the new command. However, ensure that all error messages are clear and helpful for end-users.
There was a problem hiding this comment.
Actionable comments posted: 1
Out of diff range and nitpick comments (9)
x/name/spec/03_messages.md (9)
Line range hint
3-3: Consider adding a comma after "staking" for better readability.
Line range hint
35-35: Consider adding a comma after "root" to improve the flow of the sentence.
83-83: Consider adding a comma after "owner" to enhance readability.
Line range hint
106-106: Consider adding a comma after "module" to improve readability.
Line range hint
31-33: The indentation for the unordered list items is inconsistent. Adjust to the standard indentation level.- - Insuffient length of name - - Excessive length of name - - Not deriving from the parent record (targets another root) + - Insuffient length of name + - Excessive length of name + - Not deriving from the parent record (targets another root)
Line range hint
36-36: Ensure headings are surrounded by blank lines for proper markdown formatting.+ ## MsgDeleteNameRequest +
Line range hint
28-28: Ensure lists are surrounded by blank lines for proper markdown formatting.+ This message is expected to fail if: - The parent name record does not exist - The requestor does not match the owner listed on the parent record _and_ the parent record indicates creation of child records is restricted. - The record being created is otherwise invalid due to format or contents of the name value itself +Also applies to: 56-56, 79-79, 101-101
Line range hint
38-38: Remove trailing spaces for cleaner markdown formatting.- If successful a name record will be created as described and an address index record will be created for the address associated with the name. + If successful a name record will be created as described and an address index record will be created for the address associated with the name.
Line range hint
106-106: The sectionMsgCreateRootNameRequestshould be updated or removed to reflect the removal of theCreateRootNameProposalas per the PR changes.
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- x/name/spec/03_messages.md (2 hunks)
Additional Context Used
LanguageTool (4)
x/name/spec/03_messages.md (4)
Near line 3: It appears that a comma is missing.
Context: # Messages In this section we describe the processing of the staki...
Near line 35: A comma might be missing here.
Context: ...arent record (targets another root) If successful a name record will be created as descri...
Near line 83: A comma might be missing here.
Context: ...h the gov module or the name owner. If successful a name record will be updated with the ...
Near line 106: A comma might be missing here.
Context: ...rity does not match the gov module. If successful a name record will be created with the ...
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (4)
CHANGELOG.md (4)
Line range hint
79-321: Consistent list formatting is recommended.- - + *Change all list item markers from dashes (-) to asterisks (*) for consistency throughout the document.
Line range hint
198-198: Bare URL used.Consider using Markdown link syntax to make URLs clickable and improve the readability of the document.
Line range hint
915-915: Remove spaces inside emphasis markers.- * message * + *message*Ensure that there are no spaces between the asterisks and the text inside emphasis markers for proper Markdown formatting.
Line range hint
311-311: Spaces inside code span elements.- ` code ` + `code`Remove unnecessary spaces inside code span elements to maintain clean and correct Markdown syntax.
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
x/name/types/name.pb.gois excluded by!**/*.pb.go
Files selected for processing (3)
- CHANGELOG.md (1 hunks)
- app/app.go (4 hunks)
- proto/provenance/name/v1/name.proto (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- app/app.go
- proto/provenance/name/v1/name.proto
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (3)
CHANGELOG.md (3)
Line range hint
80-325: Consistent list item markers are recommended for better readability.- * Bump cosmos-SDK to `v0.50.2` (from `v0.46.13-pio-2`) [#1772](https://github.com/provenance-io/provenance/issues/1772). + * Bump cosmos-SDK to `v0.50.2` (from `v0.46.13-pio-2`) [#1772](https://github.com/provenance-io/provenance/issues/1772).
Line range hint
199-325: Convert bare URLs to clickable links for better accessibility.- * Add support for github actions to build binary releases on tag [#30](https://github.com/provenance-io/provenance/issues/30). + * Add support for [github actions to build binary releases on tag](https://github.com/provenance-io/provenance/issues/30) [#30](https://github.com/provenance-io/provenance/issues/30).
Line range hint
80-325: Ensure consistent capitalization and punctuation in list items.- * bump cosmos-SDK to `v0.50.2` (from `v0.46.13-pio-2`) [#1772](https://github.com/provenance-io/provenance/issues/1772). + * Bump cosmos-SDK to `v0.50.2` (from `v0.46.13-pio-2`) [#1772](https://github.com/provenance-io/provenance/issues/1772).
There was a problem hiding this comment.
Actionable comments posted: 1
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- CHANGELOG.md (1 hunks)
- x/name/keeper/keeper_test.go (5 hunks)
Files skipped from review as they are similar to previous changes (1)
- x/name/keeper/keeper_test.go
There was a problem hiding this comment.
Actionable comments posted: 0
Out of diff range and nitpick comments (4)
CHANGELOG.md (4)
Line range hint
93-106: For consistency, use asterisks for unordered list items instead of dashes.- Remove `name` legacy gov proposals [#1963](https://github.com/provenance-io/provenance/pull/1963). + * Remove `name` legacy gov proposals [#1963](https://github.com/provenance-io/provenance/pull/1963).Also applies to: 177-207, 237-239, 316-338, 694-702, 747-755
Line range hint
801-801: Reduce multiple consecutive blank lines to a single blank line for better readability.- - +Also applies to: 1202-1202, 1219-1219, 1271-1271, 1375-1375
Line range hint
212-212: Format bare URLs as links for better readability.- https://keepachangelog.com/en/1.0.0/ + [https://keepachangelog.com/en/1.0.0/](https://keepachangelog.com/en/1.0.0/)Also applies to: 243-243, 342-342, 392-392, 404-404, 420-420, 491-491, 502-502, 510-510, 546-546, 571-571, 583-583, 629-629, 630-630, 631-631, 632-632, 633-633, 680-680, 721-721, 774-774, 887-887
Line range hint
929-929: Remove spaces inside emphasis markers and code span elements for proper formatting.- * message #<issue-number> + *message #<issue-number>*Also applies to: 325-325
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- CHANGELOG.md (1 hunks)
- app/app.go (4 hunks)
Files skipped from review as they are similar to previous changes (1)
- app/app.go
Additional comments not posted (1)
CHANGELOG.md (1)
74-74: The new entry for removingnamelegacy gov proposals is correctly formatted and consistent with the rest of the changelog. Good job!
* Add changelog. * Fix changelog. * Migrate proposal methods to keeper and update tests. Remove handler from app * Remove proposal messages, types, and tests. Update codec and cli. Remove simulation for proposals. * Fix name tests. * Add coderabbit suggestions. * Remove deprecated and unused proposal handlers for wasm and ibc.
Description
Removes the legacy proposal handler for the
namemodule.Related to: #1760
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passesSummary by CodeRabbit
Chores
Tests