Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove adr 038 plugin system #984

Merged
merged 5 commits into from
Aug 2, 2022
Merged

Remove adr 038 plugin system #984

merged 5 commits into from
Aug 2, 2022

Conversation

egaxhaj
Copy link
Contributor

@egaxhaj egaxhaj commented Aug 1, 2022 •
edited
Loading

Description

  • Removes ADR 038 plugin system implementation from Provenance.
  • Bumps Cosmos SDK version to v0.45.5-pio-1 from v0.45.4-pio-4 which removes ADR 038 plugin system from SDK.

closes: #983

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@egaxhaj egaxhaj requested a review from a team as a code owner August 1, 2022 17:57
@egaxhaj egaxhaj changed the title 983 remove adr 038 plugin system Remove adr 038 plugin system Aug 1, 2022
derekadams
derekadams approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@derekadams derekadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@iramiller iramiller merged commit 77b5e42 into main Aug 2, 2022
@iramiller iramiller deleted the 983-remove-adr-038-plugin-system branch August 2, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nullpointer0x00 nullpointer0x00 nullpointer0x00 approved these changes

@arnabmitra arnabmitra arnabmitra approved these changes

@derekadams derekadams derekadams approved these changes

@iramiller iramiller Awaiting requested review from iramiller

@SpicyLemon SpicyLemon Awaiting requested review from SpicyLemon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove ADR 038 plugin system
5 participants
@egaxhaj @derekadams @arnabmitra @nullpointer0x00 @iramiller