Fix for issue #220

[umatz]

Corrected wrong quotation marks.

[chris001]

@umatz Congrats on your first pull request!
If you edit also in your fork's same branch patch-1 this file:
https://github.com/umatz/Provisioner/blob/patch-1/endpoint/yealinkv70/t2x/line_keys_28.json
...then this pull request will succeed the Travis build.

[umatz]

Thanks and done :-)

…

Am 29.06.2017 um 19:11 schrieb Chris Coleman ***@***.***>: @umatz Congrats on your first pull request! If you edit also in your fork's same branch patch-1 this file: https://github.com/umatz/Provisioner/blob/patch-1/endpoint/yealinkv70/t2x/line_keys_28.json ...then this pull request will succeed the Travis build. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[chris001]

@umatz Very good!
Travis is still complaining about this error in phone.php line 57:

There was 1 error:

1) StackTest::testreplacementall

Undefined index: T27

/home/travis/build/provisioner/Provisioner/endpoint/yealinkv70/t2x/phone.php:57

[chris001]

@umatz
You should add an entry in the array $model_suffixes for T27
https://github.com/umatz/Provisioner/blob/patch-1/endpoint/yealinkv70/t2x/phone.php

[umatz]

I am not certain, whether I can use any unique id in this array ... but the checks are passing now.

[chris001]

@umatz Yes it's only failing for php 5.2 which doesn't exist any longer in Travis and so 5.2 should be removed from https://github.com/umatz/Provisioner/blob/patch-1/.travis.yml

[chris001]

Great, it's passing now. Also add php 5.5 5.6 7.0 and 7.1 because these recent php versions which the majority of well maintained systems are running right now https://github.com/umatz/Provisioner/blob/patch-1/.travis.yml

[chris001]

@umatz
The php 7.0 and 7.1 environment has a different class name for phpunit tests - supposedly.
The workaround to test php 7.x is to use phpunit 4.x or 5.x instead of the newest phpunit 6.x which Travis loads by default...

[umatz]

@chris001
Since FreePBX doesn't run under php 7.x I guess its ok to leave it at this (tests passing with php 5.5 and 5.6).

[chris001]

OK. Sangoma FreePBX team really should upgrade the PHP code soon to be compatible with PHP 7.x because PHP 5.6 has ended active support 5 months ago and is security support only for 17 more months, at that time 5.6 will be dead and subject to security attacks on irreparable vulnerabilities.

[ajoah]

Are you sure is it the good T27 suffix ? Strange that T26 suffix is 04 and T27 suffix is 27

[umatz]

Actually not, see my comment above. I could not figure out, what the ID in this array refers to.

[tm1000]

http://forum.yealink.com/forum/showthread.php?tid=1661

[chris001]

@tm1000
The T27 model and its suffix aren't listed on that forum page.
It's listed here:
http://support.yealink.com/documentFront/forwardToDocumentDetailPage?documentId=36
It seems to be 45!
It's always the first number in the firmware filename.

[umatz]

It seems to be more complicated. There are two T27 models, T27P (id 45) and T27G (id 69), source http://download.support.yealink.com/download?path=upload%2Fattachment%2F2017-3-20%2F3%2Fee202f0c-6576-4784-af5c-18f96c016815%2FYealink_IP_Phones_Auto_Provisioning_Guide_V81_70.pdf .

[chris001]

@umatz Are they same enough that you can just add entries for both T27P and T27G.
Also, your link is missing the f on the end .pdf

[umatz]

The only difference between the 27P and 27G seems to be that the G supports Gigabit Ethernet vs 100 MBit on the 27P.

[Vodochnik]

Just wondering WHY is this excellent work still not merged...