Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on current supported php versions. #230

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chris001
Copy link

@chris001 chris001 commented May 9, 2018

http://php.net/supported-versions.php
Run tests on the supported versions of PHP which are as of right now, 5.6, 7.0, 7.1, 7.2.
Letting the tests run on the older unsupported versions of PHP (5.5 and older) for information purposes only.

http://php.net/supported-versions.php
Run tests on the supported versions of PHP which are as of right now, 5.6, 7.0, 7.1, 7.2.
Letting the tests run on the older unsupported versions of PHP (5.5 and older) for information purposes only.
@tm1000
Copy link
Contributor

tm1000 commented May 9, 2018

They are all still failing however. Not sure adding the tests really matters...

@chris001
Copy link
Author

chris001 commented May 9, 2018

First this one needs to be fixed: #229 (comment)
As soon as it is fixed, this PR should be working fine, or nearly, perfect after a minor adjustment.
For the Big picture, obviously, the tests really must run cleanly on php.net published supported versions because this is software industry best practice and couldn't be more highly recommended pretty much a must for very good reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants