-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(aws): disallow child-accounts to overwrite policy for ai_services_opt_out
#6229
fix(aws): disallow child-accounts to overwrite policy for ai_services_opt_out
#6229
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6229 +/- ##
==========================================
- Coverage 90.09% 90.08% -0.02%
==========================================
Files 1181 1182 +1
Lines 36275 36315 +40
==========================================
+ Hits 32682 32713 +31
- Misses 3593 3602 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ai_services_opt_out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch @kagahd, thank you!
Please, review my comments.
...anizations_opt_out_ai_services_policy/organizations_opt_out_ai_services_policy.metadata.json
Show resolved
Hide resolved
...zations/organizations_opt_out_ai_services_policy/organizations_opt_out_ai_services_policy.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix @kagahd !
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Context
The check
organizations_opt_out_ai_services_policy
just verifies that AWS Organizations opt-out of AI services policy is enabled. However, it does not check if child-accounts are disallowed to overwrite this policy.Since the check is only checking the AWS Organizations account and not the child accounts, it's important to check that child-accounts are disallowed to overwrite the opt-out policy.
Description
This PR extends the check
organizations_opt_out_ai_services_policy
to ensure that AWS Organizations opt-out of AI services policy is enabled and that child-accounts are disallowed to overwrite this policy.Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.