Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Better "Belt test" implementation #2484

Closed
leptun opened this issue Feb 11, 2020 · 4 comments · Fixed by #2473
Closed

[ENHANCEMENT] Better "Belt test" implementation #2484

leptun opened this issue Feb 11, 2020 · 4 comments · Fixed by #2473

Comments

@leptun
Copy link
Collaborator

leptun commented Feb 11, 2020

As of now, the function always raises the Z a certain amount. raise_z_above() should be used instead.
Also the LCD rendering could be improved.

Note for later.

@vintagepc
Copy link
Contributor

I'm happy to include this in my open PR on the function.
Is there a suggested layout for the LCD rendering or is that more of a "could be better, not sure how yet"?

@leptun
Copy link
Collaborator Author

leptun commented Feb 11, 2020

The layout is mostly ok. I’m more concerned about the way the screen is rendered.

@vintagepc
Copy link
Contributor

Ah, the custom LCD_belttest_print function that redraws everything? I did think that could be cleaned up. Something more compact/efficient that only updates the relevant display section, correct?

@leptun
Copy link
Collaborator Author

leptun commented Feb 11, 2020

Yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants