G80: Fix false FINDA runout event for MK3S users #4332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gudnimg
requested review from
wavexx,
leptun,
3d-gussner,
DRracer and
vintagepc
gudnimg
force-pushed
the
fix-false-finda-runout-mk3s
branch
from
c6d532a to
d819a0b
Compare
|
wavexx
requested changes
Aug 16, 2023
gudnimg
force-pushed
the
fix-false-finda-runout-mk3s
branch
3 times, most recently
from
305fe36 to
154fe4e
Compare
wavexx
reviewed
Aug 16, 2023
wavexx
approved these changes
Aug 16, 2023
temp_compensation_start() is only called when PINDA_THERMISTOR is not defined. Additionally make sure the retraction or unretraction cannot happen twice in case MBL fails. For MK3S users with MMU this extrusion move could cause a FINDA runout event. Change in memory: Flash: -130 bytes SRAM: 0 bytes
If for some reason a user added a extrusion move in the firmware. Prevent FINDA runout from triggering. Change in memory: Flash: +16 bytes SRAM: 0 bytes
gudnimg
force-pushed
the
fix-false-finda-runout-mk3s
branch
from
d76cea1 to
a36740c
Compare
|
Rebased to merge 3 commits into 1. No code change. |
wavexx
approved these changes
Aug 16, 2023
DRracer
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a long-standing issue for MK3S (not MK3S+) users who use MMU. Also applies to MK3S printer which may have been upgraded to MK3S+. There was a short extrusion move at the end of G80 which may cause a FINDA filament runout if the EEPROM has PINDA temperature calibration set.
FINDA runout should now be completely ignored during Homing and Mesh Bed Leveling. Similarly to how the extruder filament sensor runout is ignored.
Change in memory:
Flash: -114 bytes
SRAM: 0 bytes