Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search bar losing focus while typing, layer height assertions. #13691

Closed
wants to merge 0 commits into from

Conversation

themanyone
Copy link
Contributor

@themanyone themanyone commented Nov 30, 2024

The first commit fixes problems with search dialog:

  • Search bar losing focus while typing
  • Search results dialog stealing focus even after pressing ESC
  • Search results blocking other windows after selection is made
  • Navigating the list with arrow keys
  • Scroll to the selected item when a search result is clicked

The next commit prevents assertion when switching printer to one that doesn't support current layer height.
#13705

Copy link
Contributor Author

@themanyone themanyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great so far!

@themanyone themanyone changed the title Fix search bar losing focus while typing Fix search bar losing focus while typing, layer height assertions. Dec 8, 2024
@themanyone
Copy link
Contributor Author

The latest commits work around an assertion in CoolingBuffer that was preventing fuzzy skin in vase mode. #13739

@themanyone
Copy link
Contributor Author

Save as, Ctrl+Alt+S hotkey was non-functional on Linux. And it is an odd combination to use anyway.
This patch makes Ctrl+Shift+S the "Save as" hotkey. So it is consistent across platforms.
And it also works, which is nice.

@YuSanka
Copy link
Collaborator

YuSanka commented Dec 11, 2024

Thank for your contribution. But please, don't mix several issues into one PR.
We currently work on testing of the initial state of your PR (just first commit)

@themanyone
Copy link
Contributor Author

Got it. In the future, I will make separate branches for each issue even if it's a small change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants