Remove /eth/v1/debug/beacon/states/{state_id} (#13619)

prysmaticlabs · Feb 14, 2024 · 1eb3731 · 1eb3731
1 parent b18026f
commit 1eb3731
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 49 deletions.
diff --git a/beacon-chain/rpc/eth/debug/handlers.go b/beacon-chain/rpc/eth/debug/handlers.go
@@ -19,31 +19,6 @@ import (
 
 const errMsgStateFromConsensus = "Could not convert consensus state to response"
 
-// GetBeaconStateSSZ returns the SSZ-serialized version of the full beacon state object for given state ID.
-//
-// DEPRECATED: please use GetBeaconStateV2 instead
-func (s *Server) GetBeaconStateSSZ(w http.ResponseWriter, r *http.Request) {
-	ctx, span := trace.StartSpan(r.Context(), "debug.GetBeaconStateSSZ")
-	defer span.End()
-
-	stateId := mux.Vars(r)["state_id"]
-	if stateId == "" {
-		httputil.HandleError(w, "state_id is required in URL params", http.StatusBadRequest)
-		return
-	}
-	st, err := s.Stater.State(ctx, []byte(stateId))
-	if err != nil {
-		shared.WriteStateFetchError(w, err)
-		return
-	}
-	sszState, err := st.MarshalSSZ()
-	if err != nil {
-		httputil.HandleError(w, "Could not marshal state into SSZ: "+err.Error(), http.StatusInternalServerError)
-		return
-	}
-	httputil.WriteSsz(w, sszState, "beacon_state.ssz")
-}
-
 // GetBeaconStateV2 returns the full beacon state for a given state ID.
 func (s *Server) GetBeaconStateV2(w http.ResponseWriter, r *http.Request) {
 	ctx, span := trace.StartSpan(r.Context(), "debug.GetBeaconStateV2")

diff --git a/beacon-chain/rpc/eth/debug/handlers_test.go b/beacon-chain/rpc/eth/debug/handlers_test.go
@@ -24,28 +24,6 @@ import (
 	"github.com/prysmaticlabs/prysm/v4/testing/util"
 )
 
-func TestGetBeaconStateSSZ(t *testing.T) {
-	fakeState, err := util.NewBeaconState()
-	require.NoError(t, err)
-	sszState, err := fakeState.MarshalSSZ()
-	require.NoError(t, err)
-
-	s := &Server{
-		Stater: &testutil.MockStater{
-			BeaconState: fakeState,
-		},
-	}
-
-	request := httptest.NewRequest(http.MethodGet, "http://example.com/eth/v1/debug/beacon/states/{state_id}", nil)
-	request = mux.SetURLVars(request, map[string]string{"state_id": "head"})
-	writer := httptest.NewRecorder()
-	writer.Body = &bytes.Buffer{}
-
-	s.GetBeaconStateSSZ(writer, request)
-	require.Equal(t, http.StatusOK, writer.Code)
-	assert.DeepEqual(t, sszState, writer.Body.Bytes())
-}
-
 func TestGetBeaconStateV2(t *testing.T) {
 	ctx := context.Background()
 	db := dbtest.SetupDB(t)

diff --git a/beacon-chain/rpc/service.go b/beacon-chain/rpc/service.go
@@ -293,7 +293,6 @@ func (s *Service) initializeLightClientServerRoutes(lightClientServer *lightclie
 }
 
 func (s *Service) initializeDebugServerRoutes(debugServer *debug.Server) {
-	s.cfg.Router.HandleFunc("/eth/v1/debug/beacon/states/{state_id}", debugServer.GetBeaconStateSSZ).Methods(http.MethodGet)
 	s.cfg.Router.HandleFunc("/eth/v2/debug/beacon/states/{state_id}", debugServer.GetBeaconStateV2).Methods(http.MethodGet)
 	s.cfg.Router.HandleFunc("/eth/v2/debug/beacon/heads", debugServer.GetForkChoiceHeadsV2).Methods(http.MethodGet)
 	s.cfg.Router.HandleFunc("/eth/v1/debug/fork_choice", debugServer.GetForkChoice).Methods(http.MethodGet)

diff --git a/beacon-chain/rpc/service_test.go b/beacon-chain/rpc/service_test.go
@@ -120,7 +120,6 @@ func TestServer_InitializeRoutes(t *testing.T) {
 	}
 
 	debugRoutes := map[string][]string{
-		"/eth/v1/debug/beacon/states/{state_id}": {http.MethodGet}, //deprecated
 		"/eth/v2/debug/beacon/states/{state_id}": {http.MethodGet},
 		"/eth/v2/debug/beacon/heads":             {http.MethodGet},
 		"/eth/v1/debug/fork_choice":              {http.MethodGet},