Skip to content

Commit

Permalink
James feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
terencechain committed Mar 29, 2024
1 parent d5a4f03 commit c168e79
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion beacon-chain/rpc/eth/beacon/handlers.go
Original file line number Diff line number Diff line change
Expand Up @@ -2125,7 +2125,7 @@ func (s *Server) broadcastSeenBlockSidecars(
"index": sc.Index,
"slot": sc.SignedBlockHeader.Header.Slot,
"kzgCommitment": fmt.Sprintf("%#x", sc.KzgCommitment),
}).Info("Broadcasted blob sidecar")
}).Info("Broadcasted already seen block blob sidecar")
}
return nil
}
4 changes: 2 additions & 2 deletions beacon-chain/rpc/eth/beacon/handlers_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -3652,9 +3652,9 @@ func TestServer_broadcastBlobSidecars(t *testing.T) {
blk, err := blocks.NewSignedBeaconBlock(b.Block)
require.NoError(t, err)
require.NoError(t, server.broadcastSeenBlockSidecars(context.Background(), blk, b.GetDeneb().Blobs, b.GetDeneb().KzgProofs))
require.LogsDoNotContain(t, hook, "Broadcasted blob sidecar")
require.LogsDoNotContain(t, hook, "Broadcasted already seen block blob sidecar")

server.FinalizationFetcher = &chainMock.ChainService{NotFinalized: false}
require.NoError(t, server.broadcastSeenBlockSidecars(context.Background(), blk, b.GetDeneb().Blobs, b.GetDeneb().KzgProofs))
require.LogsContain(t, hook, "Broadcasted blob sidecar")
require.LogsContain(t, hook, "Broadcasted already seen block blob sidecar")
}

0 comments on commit c168e79

Please sign in to comment.