You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I went ahead to see in which other places the helper function compute_sync_committee_period_at_slot from CL specs
has been used as slots.ToEpoch() in the already existing implementations and asked @rkapka if they were correct or not. He said they were incorrect too and we need to wrap them using slots.SyncCommitteePeriod(). One such example would be
💎 Issue
Background
@rkapka pointed out in this PR #14186
#14186 (comment)
Description
I went ahead to see in which other places the helper function
compute_sync_committee_period_at_slot
from CL specshas been used as
slots.ToEpoch()
in the already existing implementations and asked @rkapka if they were correct or not. He said they were incorrect too and we need to wrap them usingslots.SyncCommitteePeriod()
. One such example would beprysm/beacon-chain/rpc/eth/light-client/helpers.go
Line 164 in 7c81c7d
Right now the fix is blocked by #14186 as the latter is working with the same file. Once it gets merged I'll start working on this fix.
The text was updated successfully, but these errors were encountered: