Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐙 Prysm Codebase Community Feedback Tracking 🐙 #6052

Closed
5 of 12 tasks
rauljordan opened this issue May 29, 2020 · 2 comments
Closed
5 of 12 tasks

🐙 Prysm Codebase Community Feedback Tracking 🐙 #6052

rauljordan opened this issue May 29, 2020 · 2 comments
Labels
Help Wanted Extra attention is needed Tracking Gotta Catch 'Em All
Milestone

Comments

@rauljordan
Copy link
Contributor

rauljordan commented May 29, 2020

💎 Tracking Issue

Background

Yesterday, we ran a survey specifically targeting the Prysm community and contributors to let us know how they feel about the project. We received some high quality submissions and had a section where users could tell us how they feel about the docs. Here are the paraphrased, actionable responses:

🐙🐙🐙🐙🐙🐙🐙🐙🐙🐙🐙🐙🐙🐙🐙🐙🐙🐙🐙🐙🐙🐙🐙🐙🐙🐙🐙🐙🐙

  • Integrating any Prysm component into a Go module project is difficult/impossible due to bazel. Part of getting started with contributing is to take some subset and extend it your way, which is not really possible right now. Refactor dependencies, make Prysm "go gettable" #6053
  • Documenting the relations between the many features/parts of the codebase helps someone who wants to get involved
  • Remove the WebSocket subscription requirement for ETH1 nodes
  • Reduce configuration complexity, we constantly fetch BeaconConfig() over and over
  • Align naming of rewards/penalties functions closer to spec, functions such as "ApplyToEveryValidator" seem convoluted
  • Things like "ApplyToEveryValidator" seem convoluted
  • A single point of truth for some client/chain/config/etc. abstraction would be beneficial, as it is very confusing to use all the globals we currently have and various interfaces. The blockchain package needs to be much simpler and have fewer interfaces.
  • RPC/protobufs which were creating more difficulties for others debugging their client than it helped any kind of efficiency or tooling, we should be exposing the http gateway by default
  • The ethdo project is wallet-centric instead of keyfile-centric, which is a source of friction that other client teams are trying to avoid. We should aim for more standardization on that front. Will be resolved by Prysm Validator Accounts Revamp Tracking #6220
  • Trace logging is messy (fast, spammy, unformatted), log-topics would be very useful to make more sense of certain features without wading through a stream of trace logs
  • Slasher needs clear documentation and architectural overview
  • Clear, command line interfaces to deploy more than one validator and make deposits would be appreciated

Plans

Next step is to look into which of these items we want to tackle and open required issues or PRs to resolve them as needed. Some of these can be their own tracking issues.

@rauljordan rauljordan added Help Wanted Extra attention is needed Tracking Gotta Catch 'Em All labels May 29, 2020
@rauljordan rauljordan added this to the Diamond milestone May 29, 2020
@terencechain
Copy link
Member

I'll take on The blockchain package needs to be much simpler and have fewer interfaces.

@prestonvanloon prestonvanloon pinned this issue Jun 3, 2020
@rauljordan rauljordan unpinned this issue Oct 12, 2020
@rauljordan
Copy link
Contributor Author

This one is more of a list of generic problems which do not have clear, actionable PRs as resolutions compared to other open issues. Instead, this will be fixed by a combination of #6534, improving our logging, and adding documentation for items such as slasher. It is also related to #7514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Extra attention is needed Tracking Gotta Catch 'Em All
Projects
None yet
Development

No branches or pull requests

2 participants