-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor dependencies, make Prysm "go gettable" #6053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update libs * add new validators * add new deps * new set of deps * tls * further fix gossip update * get everything to build * clean up * gaz * fix build * fix all tests * add deps to images * imports Co-authored-by: rauljordan <raul@prysmaticlabs.com>
…ser index in test
…he proposer index in test" This reverts commit 4367689.
prestonvanloon
requested review from
terencechain,
nisdas,
rauljordan,
0xKiwi,
farazdagi and
shayzluf
May 30, 2020 21:57
rauljordan
approved these changes
May 31, 2020
nisdas
approved these changes
May 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great
12 tasks
This was referenced Jun 1, 2020
@prestonvanloon this is awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
At Prysmatic Labs, we use the Bazel build tool for many reasons including:
However, we recognize that Bazel build tooling adds friction to the average go developer. As such, we would like to provide first class support for go build/test. Additionally, for those users that wish to build upon Prysm with bazel, we're providing a
prysm_deps()
starlark rule that can be loaded in the downstream WORKSPACE.Which issues(s) does this PR fix?
Fixes #6035 (go build)
Fixes #6005 (deps refactor for downstream users)
Fixes #6011 (update deps to recent version)
Other notes for review
** Diff is large due to generated files. **
Please review:
Other notable changes: