stategen: Pre-populate bls pubkey cache as part of stategen's Resume function #11482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… This adds some helpers and a benchmark to blst
prestonvanloon
commented
Sep 21, 2022
| var maxKeys = 1000000 | ||
| var maxKeys = 1_000_000 |
There was a problem hiding this comment.
This is cosmetic only. Easier to read this way.
prestonvanloon
commented
Sep 21, 2022
Comment on lines
+107
to
+121
| b.Run("cache on", func(b *testing.B) { | ||
| blst.EnableCaches() | ||
| for i := 0; i < b.N; i++ { | ||
| _, err := blst.PublicKeyFromBytes(pubkeyBytes) | ||
| require.NoError(b, err) | ||
| } | ||
| }) | ||
|
|
||
| b.Run("cache off", func(b *testing.B) { | ||
| blst.DisableCaches() | ||
| for i := 0; i < b.N; i++ { | ||
| _, err := blst.PublicKeyFromBytes(pubkeyBytes) | ||
| require.NoError(b, err) | ||
| } | ||
| }) |
There was a problem hiding this comment.
goos: linux
goarch: amd64
cpu: Intel(R) Core(TM) i7-8565U CPU @ 1.80GHz
BenchmarkPublicKeyFromBytes/cache_on-8 12787650 101.9 ns/op
BenchmarkPublicKeyFromBytes/cache_off-8 16531 73187 ns/op
PASS
rauljordan
previously approved these changes
May 7, 2023
rauljordan
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
At the start of initial sync, much of the work is converting bytes to blst pubkeys. This work of turning
[]byteintoblst.PubKeyis a significant part of the initial sync pprof flame.So this PR introduces a one time routine to iterate over the finalized state validator list to convert / insert all of the pubkeys into the cache.
This allows Prysm to sync at it's max sync speed from the start, although it does not reduce the total time to sync.
Which issues(s) does this PR fix?
Other notes for review
Needs a bit more testing.