Add (lack of) REST implementation for GetFeeRecipientByPubKey
#11991
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
Related gitHub issue:
#11580
How other validator clients implementation deals with this issue: ethereum/keymanager-APIs#55
What does this PR do? Why is it needed?
This PR deals with the (lack of) implementation for the
GetFeeRecipientByPubKey
method in beacon API.With gRPC implementation, if, for a given
{pubkey}
:{pubkey}
specific fee recipient is set in validator client, ANDGetFeeRecipientByPubKey
gRPC beacon API call responds on error, then:Before this PR, the call to
GET /eth/v1/validator/{pubkey}/feerecipient
returns the burn address0x0000....
After this PR the call to
GET /eth/v1/validator/{pubkey}/feerecipient
returns:With gRPC implementation, if, for a given
{pubkey}
:{pubkey}
specific fee recipient is set in validator client, ANDGetFeeRecipientByPubKey
gRPC beacon API call responds with anil
value or with an empty value, then:Before this PR, the call to
GET /eth/v1/validator/{pubkey}/feerecipient
returns the burn address0x0000....
After this PR the call to
GET /eth/v1/validator/{pubkey}/feerecipient
returns:With beacon API implementation, if, for a given
{pubkey}
:{pubkey}
specific fee recipient is set in validator client, ANDthe call to
GET /eth/v1/validator/{pubkey}/feerecipient
returns:Warning:
The 400 and 500 code listed above will cause, in Prysm validator WebUI, the following error:
Edit:
After prysmaticlabs/prysm-web-ui#242: