Prysm v4 - mark old endpoints for deprecation #11997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
requested changes
Feb 17, 2023
james-prysm
commented
Feb 21, 2023
| @@ -56,6 +56,7 @@ func (e *blockIdParseError) Error() string { | |||
|
|
|||
| // GetWeakSubjectivity computes the starting epoch of the current weak subjectivity period, and then also | |||
| // determines the best block root and state root to use for a Checkpoint Sync starting from that point. | |||
| // DEPRECATED: GetWeakSubjectivity endpoint will no longer be supported | |||
There was a problem hiding this comment.
I need to set the deprecated message at the bottom to conform to linting , requires comments to start with public function name
There was a problem hiding this comment.
Let's go ahead and say it is no longer supported. We won't rugpull this endpoint, but we are no longer supporting it now.
rkapka
reviewed
Feb 22, 2023
| @@ -92,6 +92,7 @@ var ( | |||
| // Note that this will stream information whilst syncing; this is intended, to allow for complete validator state capture | |||
| // over time. If this is not required then the client can either wait until the beacon node is synced, or filter results | |||
| // based on the epoch value in the returned validator info. | |||
| // DEPRECATED: Streaming Validator Info is nolonger supported, the /eth/v1/events Beacon API endpoint will stream events and | |||
| @@ -56,6 +56,7 @@ func (e *blockIdParseError) Error() string { | |||
|
|
|||
| // GetWeakSubjectivity computes the starting epoch of the current weak subjectivity period, and then also | |||
| // determines the best block root and state root to use for a Checkpoint Sync starting from that point. | |||
| // DEPRECATED: GetWeakSubjectivity endpoint will no longer be supported | |||
There was a problem hiding this comment.
Let's go ahead and say it is no longer supported. We won't rugpull this endpoint, but we are no longer supporting it now.
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
Co-authored-by: Radosław Kapka <rkapka@wp.pl>
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
rkapka
approved these changes
Feb 22, 2023
rauljordan
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
We are beginning the process of deprecation for several old endpoints in favor of new ones or in favor of changed design choices. This initial PR addresses endpoints that are either unused or superseded by a newer API.
also removing a storage folder that was unused.
Which issues(s) does this PR fix?
related to #11841