prysmctl: check capella fork for blstoexecutionchange #12039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potuz
approved these changes
Feb 24, 2023
| @@ -87,6 +89,13 @@ func callWithdrawalEndpoints(ctx context.Context, host string, request []*apimid | |||
| if err != nil { | |||
| return err | |||
| } | |||
| fork, err := client.GetFork(ctx, "head") | |||
There was a problem hiding this comment.
Isn't it simpler to check that CapellaForkEpoch is set and then that current epoch is higher than that?
There was a problem hiding this comment.
yeah that's true, at first I thought I somehow I could compare the output of fork response with version.Capella somehow and winded up on this road 😓
They are but the idea is not making it easier for users to shoot their feet by including them now. And only allow these changes to be post-Capella. Users that insist on flooding the fork should find their way |
delete-merged-branch
bot
deleted the
prysmctl-withdrawal-fork-restriction
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Adding in fork checking to make sure capella is enabled before submitting blstoexecutionchanges as the api endpoint does not throw an error for messages prior to the fork.