Update cross compile toolchains #12069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvanloon
commented
Mar 1, 2023
Comment on lines
-47
to
-50
| build:docker-sandbox --host_javabase=@rbe_ubuntu_clang//java:jdk | ||
| build:docker-sandbox --javabase=@rbe_ubuntu_clang//java:jdk | ||
| build:docker-sandbox --host_java_toolchain=@bazel_tools//tools/jdk:toolchain_hostjdk8 | ||
| build:docker-sandbox --java_toolchain=@bazel_tools//tools/jdk:toolchain_hostjdk8 |
There was a problem hiding this comment.
These flags were deprecated in bazel 5.0.0. See bazelbuild/bazel#7849
prestonvanloon
commented
Mar 1, 2023
Comment on lines
-17
to
+59
| | target | linux_amd64 | linux_arm64 | osx_amd64 | osx_arm64 | windows_amd64 | | ||
| |------------------|-------------------|------------------|-----------------|-----------------|-----------------------------------| | ||
| | target | linux_amd64 | linux_arm64 | osx_amd64 | osx_arm64 | windows_amd64 | | ||
| |------------------|--------------------------------------------------------------------|--------------------------------------------|------------------------------------|------------------------------------|------------------------------------| | ||
| | `//beacon-chain` | :heavy_check_mark: docker-sandbox and RBE, supported locally only | :heavy_check_mark: docker-sandbox and RBE | :heavy_check_mark: docker-sandbox | :heavy_check_mark: docker-sandbox | :heavy_check_mark: docker-sandbox | | ||
| | `//validator` | :heavy_check_mark: docker-sandbox and RBE | :heavy_check_mark: docker-sandbox and RBE | :heavy_check_mark: docker-sandbox | :heavy_check_mark: docker-sandbox | :heavy_check_mark: | | ||
| | `//validator` | :heavy_check_mark: docker-sandbox and RBE | :heavy_check_mark: docker-sandbox and RBE | :heavy_check_mark: docker-sandbox | :heavy_check_mark: docker-sandbox | :heavy_check_mark: | |
There was a problem hiding this comment.
Formatting changes here, it looks good on widescreen, i promise!
prestonvanloon
commented
Mar 1, 2023
Comment on lines
+68
to
+70
| |-------------------------------|----------------------------|-----------------------------|---------------------------|---------------------------|-------------------------------| | ||
| | Local run | `linux_amd64` | `linux_arm64` | `osx_amd64` | `osx_arm64` | `windows_amd64` | | ||
| | Docker sandbox | `linux_amd64_docker` | `linux_arm64_docker` | `osx_amd64_docker` | `osx_arm64_docker` | `windows_amd64_docker ` | |
There was a problem hiding this comment.
Formatting changes here, it looks good on widescreen, i promise!
prestonvanloon
commented
Mar 1, 2023
| @@ -0,0 +1,202 @@ | |||
|
|
|||
| Apache License | |||
There was a problem hiding this comment.
This Apache license was generated by the cli tool. I think it's OK to leave it.
…ysm into update-tools-crosschain
|
Need to test cross compiled binaries work on the various platforms. Will test tomorrow. |
|
Confirmed basic sanity checks of darwin_amd64 and windows_amd64. Cross compile appears to be working as it did before these changes. |
rauljordan
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
rbe_autoconfigfrom bazel-toolchains has been deprecated since bazel 4 and is no longer supported. The canonical way is now to use the rbe_configs_gen CLI tool. This PR updates the cross compilation toolchains to use new configs generated by that CLI tool and updates the README instructions for maintaining these configs.Which issues(s) does this PR fix?
This removes some annoying warnings that bazel was showing on every build.
Other notes for review