Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark GetChainHead deprecated #12128

Merged
merged 7 commits into from
Mar 14, 2023
Merged

Conversation

terencechain
Copy link
Member

Marking GetChainHead which enables greater clean up in #12127. Unfortunately, we couldn't merge #12127 for V4 release due to lack of deprecation notice. We'll have to wait for V5

@terencechain terencechain added Ready For Review A pull request ready for code review OK to merge labels Mar 14, 2023
@terencechain terencechain requested a review from a team as a code owner March 14, 2023 18:40
@terencechain terencechain self-assigned this Mar 14, 2023
Copy link
Member

@prestonvanloon prestonvanloon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please mark the RPC endpoint as deprecated in the proto too?

proto/prysm/v1alpha1/beacon_chain.proto

terencechain and others added 2 commits March 14, 2023 12:00
Co-authored-by: Preston Van Loon <preston@prysmaticlabs.com>
@prylabs-bulldozer prylabs-bulldozer bot merged commit 5c234c8 into develop Mar 14, 2023
@delete-merged-branch delete-merged-branch bot deleted the mark-chain-head-deprecated branch March 14, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants