Fix payload attributes json #12169
Merged
Fix payload attributes json #12169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avalonche
force-pushed
the
payload-attributes-json
branch
from
4d181cc to
82a4c46
Compare
avalonche
force-pushed
the
payload-attributes-json
branch
from
82a4c46 to
5649656
Compare
|
thanks for catching this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
The specs don't specify a
_v2suffix to be added as part of the json field name, only that the version matches with the payload attributes. This is also inconsistent with lighthouse's implementation.Which issues(s) does this PR fix?
Fixes #
Other notes for review