Recover State Summary Correctly #12214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We don't have the metric in stategen, which is why I havent added in anything new. Basically just followed how we handled it in stategen |
Comment on lines
+486
to
+499
| func (s *Service) recoverStateSummary(ctx context.Context, blockRoot [32]byte) (*ethpb.StateSummary, error) { | ||
| if s.cfg.BeaconDB.HasBlock(ctx, blockRoot) { | ||
| b, err := s.cfg.BeaconDB.Block(ctx, blockRoot) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| summary := ðpb.StateSummary{Slot: b.Block().Slot(), Root: blockRoot[:]} | ||
| if err := s.cfg.BeaconDB.SaveStateSummary(ctx, summary); err != nil { | ||
| return nil, err | ||
| } | ||
| return summary, nil | ||
| } | ||
| return nil, errBlockDoesNotExist | ||
| } |
There was a problem hiding this comment.
Want to add a test for this method?
Comment on lines
520
to
526
|
|
||
| _, err = c.IsOptimisticForRoot(ctx, optimisticRoot) | ||
| require.ErrorContains(t, "nil summary returned from the DB", err) | ||
|
|
||
| require.NoError(t, beaconDB.SaveStateSummary(context.Background(), ðpb.StateSummary{Root: optimisticRoot[:], Slot: 11})) | ||
| optimistic, err := c.IsOptimisticForRoot(ctx, optimisticRoot) | ||
| require.NoError(t, err) | ||
| require.Equal(t, true, optimistic) | ||
|
|
||
| require.NoError(t, beaconDB.SaveStateSummary(context.Background(), ðpb.StateSummary{Root: validatedRoot[:], Slot: 9})) | ||
| cp := ðpb.Checkpoint{ | ||
| Epoch: 1, |
There was a problem hiding this comment.
Could you add some kind of regression test? This might be the test already, but you can assert that = BeaconDB.StateSummary returns nil and returns non-nil after calling IsOptimisticForRoot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug Fix
What does this PR do? Why is it needed?
In the event we have the referenced block in our database but not its summary, we fallback and correctly recover it.
Which issues(s) does this PR fix?
Fixes #12208
Other notes for review