Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to boost local block value #12227

Merged
merged 7 commits into from
Apr 4, 2023
Merged

Conversation

terencechain
Copy link
Member

@terencechain terencechain commented Apr 3, 2023

This pull request adds a new flag to local-block-value-boost that allows the local block value multiplied by the boost value. The resulting value will be used if higher than the original builder's bid value.
(i.e builder_bid_value * 100 > local_block_value * (local-block-value-boost + 100)

By default, the boost value is set to 0. This means that the current behavior remains unchanged. However, if preferred, the value of the boost can be adjusted to shift prioritization to the local block

The proposed change is designed to provide greater flexibility in censorship resistance defense, allowing for more dynamic and potentially more competitive bidding between local builders and mev builders

…ilder bid if (bid * fraction) > local block value
@terencechain terencechain added the Builder PR or issue that supports builder related work label Apr 3, 2023
…tion using a boost value for local block construction
@terencechain terencechain changed the title Add flag to multiply builder bid with local block value Add flag to boost local block value Apr 3, 2023
@terencechain terencechain force-pushed the builder-bid-fraction branch from ef54092 to e643bfd Compare April 3, 2023 18:01
@terencechain terencechain marked this pull request as ready for review April 3, 2023 21:17
@terencechain terencechain requested a review from a team as a code owner April 3, 2023 21:17
@terencechain terencechain requested review from saolyn, potuz and rkapka April 3, 2023 21:17
Copy link
Contributor

@potuz potuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we perhaps assign a non-zero default value for this flag?

@@ -83,8 +91,9 @@ func (vs *Server) setExecutionData(ctx context.Context, blk interfaces.SignedBea
}
}
log.WithFields(logrus.Fields{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This log will be printed even if the value was higher but the withdrawals didn't match.

@prylabs-bulldozer prylabs-bulldozer bot merged commit 35e3eed into develop Apr 4, 2023
@delete-merged-branch delete-merged-branch bot deleted the builder-bid-fraction branch April 4, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builder PR or issue that supports builder related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants