-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag to boost local block value #12227
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilder bid if (bid * fraction) > local block value
…tion using a boost value for local block construction
terencechain
changed the title
Add flag to multiply builder bid with local block value
Add flag to boost local block value
Apr 3, 2023
terencechain
force-pushed
the
builder-bid-fraction
branch
from
April 3, 2023 18:01
ef54092
to
e643bfd
Compare
potuz
requested changes
Apr 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we perhaps assign a non-zero default value for this flag?
@@ -83,8 +91,9 @@ func (vs *Server) setExecutionData(ctx context.Context, blk interfaces.SignedBea | |||
} | |||
} | |||
log.WithFields(logrus.Fields{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This log will be printed even if the value was higher but the withdrawals didn't match.
potuz
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new flag to
local-block-value-boost
that allows the local block value multiplied by the boost value. The resulting value will be used if higher than the original builder's bid value.(i.e
builder_bid_value * 100 > local_block_value * (local-block-value-boost + 100
)By default, the boost value is set to 0. This means that the current behavior remains unchanged. However, if preferred, the value of the boost can be adjusted to shift prioritization to the local block
The proposed change is designed to provide greater flexibility in censorship resistance defense, allowing for more dynamic and potentially more competitive bidding between local builders and mev builders