-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build tag to exclude mainnet genesis from prysmctl #12244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this locally
Before: 65334646 bytes
After: 65336792 bytes
Appears to be larger somehow. Did it work for you with bazel?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what my issues were locally. I believe that your changes would work. Looks good to me
What type of PR is this?
Feature
What does this PR do? Why is it needed?
This is one small step to reducing the binary size of prysmctl. We'll get much bigger benefits from excluding validator web ui data, but since those are generated files it will take some more work to figure out how to accomplish that through bazel.