Fix Next State Mismatch #12247
Merged
Fix Next State Mismatch #12247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
added
Ready For Review
potuz
requested changes
Apr 6, 2023
potuz
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug Fix
What does this PR do? Why is it needed?
In E2E a few of our runs were constantly failing with
could not process slots: expected state.slot 289 < slot 288. After an investigation it was determined that #12233 added the ability for our cache to store different states with the same parent root. To allow the next slot cache to return the correctly desired state to the caller, we added in awantedSlotparameter which should allow states with the desired slots to be returned.A simple regression test was also added for this.
Which issues(s) does this PR fix?
N.A
Other notes for review