prysmctl: Add support for writing signed validator exits to disk #12262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
reviewed
Apr 17, 2023
| @@ -230,6 +230,12 @@ var ( | |||
| Name: "force-exit", | |||
| Usage: "Exit without displaying the confirmation prompt", | |||
| } | |||
| VoluntaryExitJSONOutputPath = &cli.StringFlag{ | |||
There was a problem hiding this comment.
you need to add this to the usage.go file I believe otherwise it won't show up in help
There was a problem hiding this comment.
It only applies to subcommands in prysmctl and validator. I put this flag everywhere that ForceExit appears
james-prysm
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
Adds support for saving validator exits as a JSON file.
This is intended to be used with lido ejector in messages mode
Which issues(s) does this PR fix?
Other notes for review