Fix capella unblind block with bls field #12263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
added
Bug
potuz
previously approved these changes
Apr 13, 2023
potuz
previously approved these changes
Apr 13, 2023
…lind-block-bls-field
…s/prysm into fix-unblind-block-bls-field
nisdas
approved these changes
Apr 13, 2023
4 tasks
This was referenced Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
When we attempt to unblind a block in Capella, we send the block to the relayer via
SubmitBlindedBlock. Before the call, prysm miss to includebls-to-execobject in the blind block itself. As a result, the relayer will get a signature verification error because the hash tree root would be different than before. This PR adds thebls-to-execfield.Expect a post mortem from this shortly