Enable whitespace linter & fix findings #12273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtraglia
commented
Apr 13, 2023
| @@ -188,7 +188,7 @@ func Mod64(a, b uint64) (uint64, error) { | |||
| return val, nil | |||
| } | |||
|
|
|||
| // Int returns the integer value of the uint64 argument. If there is an overlow, then an error is | |||
| // Int returns the integer value of the uint64 argument. If there is an overflow, then an error is | |||
There was a problem hiding this comment.
Also, fixes this one typo I noticed.
terencechain
previously approved these changes
Apr 14, 2023
rkapka
previously approved these changes
Apr 17, 2023
|
Hi @jtraglia , the build fails at the moment. |
Fixed 😄 |
prestonvanloon
previously approved these changes
Apr 17, 2023
|
I fixed the conflicts. Not sure why github was too dumb to figure out that a file was renamed in whole. There was no conflict resolution required locally /shrug |
prestonvanloon
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Removes all of the unnecessary whitespace. Enables the
whitespacelinter to catch this in the future.