Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly use Gwei to compare builder bid value #12290

Merged
merged 2 commits into from
Apr 16, 2023
Merged

Correctly use Gwei to compare builder bid value #12290

merged 2 commits into from
Apr 16, 2023

Conversation

potuz
Copy link
Contributor

@potuz potuz commented Apr 15, 2023

Correctly convert to Gwei to compare builder's block value

Fixes #12289

@potuz potuz added Bug Something isn't working Ready For Review A pull request ready for code review Priority: High High priority item labels Apr 15, 2023
@potuz potuz requested a review from a team as a code owner April 15, 2023 18:41
terencechain
terencechain previously approved these changes Apr 15, 2023
View reviewed changes
@nisdas nisdas merged commit 191b0c4 into develop Apr 16, 2023
@delete-merged-branch delete-merged-branch bot deleted the use_gwei_blockvalue branch April 16, 2023 08:47
@redowk
Copy link

redowk commented Apr 16, 2023

is there an ETA for when will this fix reach release? thank you.

@terencechain
Copy link
Member

is there an ETA for when will this fix reach release? thank you.

in the next few days

@terencechain terencechain mentioned this pull request Apr 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nisdas nisdas nisdas approved these changes

@terencechain terencechain terencechain approved these changes

@prestonvanloon prestonvanloon Awaiting requested review from prestonvanloon prestonvanloon is a code owner automatically assigned from prysmaticlabs/core-team

@saolyn saolyn Awaiting requested review from saolyn saolyn is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
Bug Something isn't working Priority: High High priority item Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mev-boost got a good best bid with larger reward, but Prysm still built locally with a small reward.
4 participants
@potuz @redowk @terencechain @nisdas