Fix Broken Dependency #12293
Merged
Fix Broken Dependency #12293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
added
Ready For Review
terencechain
previously approved these changes
Apr 17, 2023
terencechain
approved these changes
Apr 17, 2023
|
This PR breaks builds for windows.
|
Comment on lines
-11
to
+14
| deps = select({ | ||
| "@io_bazel_rules_go//go/platform:android": [ | ||
| "@com_github_wercker_journalhook//:go_default_library", | ||
| ], | ||
| "@io_bazel_rules_go//go/platform:linux": [ | ||
| "@com_github_wercker_journalhook//:go_default_library", | ||
| ], | ||
| "//conditions:default": [], | ||
| }), | ||
| deps = [ | ||
| "@com_github_coreos_go_systemd//journal:go_default_library", | ||
| "@com_github_sirupsen_logrus//:go_default_library", |
There was a problem hiding this comment.
We need this conditional again to restore windows builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Dependency Fix
What does this PR do? Why is it needed?
This vendors the broken dependency into prysm so that we no longer will need to import it or any
of its forks.
Which issues(s) does this PR fix?
Supersedes #12292
Other notes for review