Return errors from ProduceBlindedBlock
#12309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
added
Ready For Review
saolyn
reviewed
Apr 19, 2023
terencechain
requested changes
Apr 19, 2023
There was a problem hiding this comment.
I don't think this is correct, the beacon api stated the return should be blinded block or error. In this case, wouldn't error be most appropriate
Really the best option is to fix the underly inefficiency so it actually can return blind block instead of error
rkapka
changed the title
ProduceBlindedBlockProduceBlindedBlock
james-prysm
previously approved these changes
Apr 20, 2023
james-prysm
approved these changes
Apr 20, 2023
terencechain
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
ProduceBlindedBlockcurrently assumes that v1alpha1 server will return blinded blocks. This doesn't have to be true. When we get a full block or the builder is not configured, we won't be able to deal with the block so we should return an error.Which issues(s) does this PR fix?
Part of #12103