Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Exceptions For Transaction Fuzzer #12313

Merged
merged 2 commits into from
Apr 20, 2023
Merged

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Apr 20, 2023

What type of PR is this?

E2E Fix

What does this PR do? Why is it needed?

In #12270, we returned errors in our transaction fuzzer if a transaction wasn't able to be successfully completed. However due
to the nature of how the fuzzer constructs transactions, this would always be a possibility. The end result is that our e2e runs started failing much more often. This PR adds in exceptions for them so that we don't need to return errors if a transaction isn't valid.

Which issues(s) does this PR fix?

N.A

Other notes for review

@nisdas nisdas added the Ready For Review A pull request ready for code review label Apr 20, 2023
@nisdas nisdas requested a review from a team as a code owner April 20, 2023 14:24
@nisdas nisdas requested review from kasey, potuz and james-prysm April 20, 2023 14:24
@prylabs-bulldozer prylabs-bulldozer bot merged commit 6374cc0 into develop Apr 20, 2023
@delete-merged-branch delete-merged-branch bot deleted the removeErrorReturn branch April 20, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants