Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use same signature for unrealized justified hash and justified hash #12314

Merged
merged 2 commits into from
Apr 20, 2023
Merged

Use same signature for unrealized justified hash and justified hash #12314

merged 2 commits into from
Apr 20, 2023

Conversation

potuz
Copy link
Contributor

@potuz potuz commented Apr 20, 2023

Do not return an error if the unrealized justified hash is not known.

@potuz potuz requested a review from a team as a code owner April 20, 2023 15:29
terencechain
terencechain previously approved these changes Apr 20, 2023
View reviewed changes
@prylabs-bulldozer prylabs-bulldozer bot merged commit 300a827 into develop Apr 20, 2023
@delete-merged-branch delete-merged-branch bot deleted the dont_error_unrealized_blockchash branch April 20, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nisdas nisdas nisdas approved these changes

@terencechain terencechain terencechain left review comments

@rauljordan rauljordan Awaiting requested review from rauljordan rauljordan is a code owner automatically assigned from prysmaticlabs/core-team

@prestonvanloon prestonvanloon Awaiting requested review from prestonvanloon prestonvanloon is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@potuz @terencechain @nisdas