Move some errors to separate consensus-types package
#12329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
added
Ready For Review
prestonvanloon
previously approved these changes
Apr 25, 2023
rkapka
changed the title
ErrNilObjectWrapped to separate packageconsensus-types package
saolyn
reviewed
Apr 25, 2023
| @@ -5,6 +5,7 @@ import ( | |||
|
|
|||
| "github.com/pkg/errors" | |||
| ssz "github.com/prysmaticlabs/fastssz" | |||
| consensus_types "github.com/prysmaticlabs/prysm/v4/consensus-types" | |||
There was a problem hiding this comment.
Should we not be using camel case instead of snake case? My IDE complains
Or alternatively just consensustypes
There was a problem hiding this comment.
Ideally it should me consensustypes. But Goland's intellisense uses snaka case and it's very annoying to convert every file manually, so I just leave it as it is.
saolyn
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Cleanup
What does this PR do? Why is it needed?
ErrNilObjectWrapped,ErrUnsupportedGetterandErrNotSupportedall currently live in theblockspackage, but they are applicable to all consensus types. This PR moves these members out to the top-levelconsensus-typespackage.