blockchain: add more spans to analyze block production timing #12332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, need to fix one thing first |
prestonvanloon
commented
Apr 25, 2023
| @@ -148,7 +151,7 @@ func (s *Service) UpdateHead(ctx context.Context, proposingSlot primitives.Slot) | |||
| }).Debug("Head changed due to attestations") | |||
| } | |||
| s.headLock.RUnlock() | |||
| if err := s.forkchoiceUpdateWithExecution(s.ctx, newHeadRoot, proposingSlot); err != nil { | |||
| if err := s.forkchoiceUpdateWithExecution(ctx, newHeadRoot, proposingSlot); err != nil { | |||
There was a problem hiding this comment.
Please see my note in beacon-chain/blockchain/forkchoice_update_execution.go#L56
prestonvanloon
added
Ready For Review
terencechain
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
Adds some additional spans to properly group and analyze data during block production when tracing is enabled.
Which issues(s) does this PR fix?
Other notes for review