Fix committee test race #12338
Merged
Fix committee test race #12338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beacon-chain/cache/sync_committee.go
Outdated
| @@ -162,6 +181,9 @@ func (s *SyncCommitteeCache) UpdatePositionsInCommittee(syncCommitteeBoundaryRoo | |||
|
|
|||
| s.lock.Lock() | |||
| defer s.lock.Unlock() | |||
| if clearCount != s.cleared.Load() { | |||
| return errors.New("cache rotated during async committee update operation") | |||
There was a problem hiding this comment.
Any thoughts on logging the error and returning nil vs. returning the error?
Question is whether this error should fail block processing
There was a problem hiding this comment.
It's a bummer that we even need to consider this, but I agree that I don't want to create an issue in block processing, because strict ordering of cache updates so far seems to only be an issue in tests. But I don't like how the current design requires so much care to avoid races, so I'm inclined to go ahead and log for now, then return to improving this design when we audit cache implementations.
terencechain
previously approved these changes
Apr 26, 2023
nisdas
previously approved these changes
Apr 27, 2023
nisdas
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
Helps eliminate a class of unit tests races caused by asyncronous updating of the sync committee cache. This is accomplished by more carefully managing access to the cache value, canceling the async update if the underlying cache has been re-initialized, which only happens in the test code path.