-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use max cover on unaggregated atts nor check subgroup of validated signatures #12350
Merged
prylabs-bulldozer
merged 5 commits into
develop
from
aggregate_unnaggregated_without_max_cover
May 16, 2023
Merged
Don't use max cover on unaggregated atts nor check subgroup of validated signatures #12350
prylabs-bulldozer
merged 5 commits into
develop
from
aggregate_unnaggregated_without_max_cover
May 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potuz
force-pushed
the
aggregate_unnaggregated_without_max_cover
branch
from
May 16, 2023 15:18
9e7aaa4
to
a932d9e
Compare
potuz
added
Ready For Review
A pull request ready for code review
Priority: High
High priority item
labels
May 16, 2023
proto/prysm/v1alpha1/attestation/aggregation/attestations/attestations.go
Outdated
Show resolved
Hide resolved
potuz
changed the title
Don't use max cover on unnaggregated atts
Don't use max cover on unaggregated atts nor check subgroup of validated signatures
May 16, 2023
potuz
force-pushed
the
aggregate_unnaggregated_without_max_cover
branch
from
May 16, 2023 15:30
a932d9e
to
b07032f
Compare
terencechain
previously approved these changes
May 16, 2023
potuz
force-pushed
the
aggregate_unnaggregated_without_max_cover
branch
from
May 16, 2023 16:26
a36d487
to
a64a6f9
Compare
terencechain
previously approved these changes
May 16, 2023
terencechain
previously approved these changes
May 16, 2023
rauljordan
approved these changes
May 16, 2023
rauljordan
previously approved these changes
May 16, 2023
prestonvanloon
previously approved these changes
May 16, 2023
potuz
dismissed stale reviews from prestonvanloon, terencechain, and rauljordan
via
May 16, 2023 16:55
d68a894
terencechain
approved these changes
May 16, 2023
terencechain
approved these changes
May 16, 2023
prylabs-bulldozer
bot
deleted the
aggregate_unnaggregated_without_max_cover
branch
May 16, 2023 17:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things
These numbers were run on a NUC i5-8259U
On 293 aggregations, the average on mainnet were
variation happened up to 3500ms on the first batch regularly (hence the high standard deviation).
At 9 seconds it got regularly > 1000 ms and both second and third batches had standard deviation of 100%.
With the PR applied we obtain
Variation happened up to 2256ms in a couple of places.