Fix Key Filtering In Validator #12358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
added
Ready For Review
Comment on lines
-1053
to
+1054
| statusRequestKeys = append(statusRequestKeys, k[:]) | ||
| copiedk := k | ||
| statusRequestKeys = append(statusRequestKeys, copiedk[:]) |
There was a problem hiding this comment.
There is a static analysis that catches this, i wonder why it didnt do it here? It's called loopclosure.
prestonvanloon
approved these changes
May 5, 2023
|
Wow thanks I'm surprised nothing else caught this in my tests |
james-prysm
approved these changes
May 5, 2023
terencechain
pushed a commit
that referenced
this pull request
May 5, 2023
terencechain
pushed a commit
that referenced
this pull request
May 5, 2023
terencechain
pushed a commit
that referenced
this pull request
May 5, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug Fix
What does this PR do? Why is it needed?
In #12322 we introduced the ability to filter keys based on the current validator status. However the change introduced a bug which lead to only 1 key being passed into the
MultipleValidatorStatusrequest. For an example on how this would happen:https://go.dev/play/p/1cPEh5fYIvx
The PR copies the key and appends it to the slice along with modifying the unit test so that this particular case can be caught correctly.
Which issues(s) does this PR fix?
N.A
Other notes for review