Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do Not Panic on Broadcasting Nil Object #12369

Merged
merged 1 commit into from
May 7, 2023
Merged

Do Not Panic on Broadcasting Nil Object #12369

merged 1 commit into from
May 7, 2023

Conversation

rauljordan
Copy link
Contributor

@rauljordan rauljordan commented May 7, 2023 •
edited
Loading

Two broadcast methods, namely for attestations and sync committees, can panic a node if we try to broadcast nil objects. Instead, we fail early and return an error. Closes #11926

@rauljordan rauljordan requested a review from a team as a code owner May 7, 2023 04:43
@rauljordan rauljordan added the Ready For Review A pull request ready for code review label May 7, 2023
@prylabs-bulldozer prylabs-bulldozer bot merged commit 6f383f2 into develop May 7, 2023
@prylabs-bulldozer prylabs-bulldozer bot deleted the no-panic-on-broadcast branch May 7, 2023 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terencechain terencechain terencechain approved these changes

@saolyn saolyn Awaiting requested review from saolyn saolyn is a code owner automatically assigned from prysmaticlabs/core-team

@nisdas nisdas Awaiting requested review from nisdas nisdas is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recovery from panic when broadcast
2 participants
@rauljordan @terencechain