Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore disable-peer-scorer flag #12386

Merged
merged 3 commits into from
May 23, 2023
Merged

Restore disable-peer-scorer flag #12386

merged 3 commits into from
May 23, 2023

Conversation

prestonvanloon
Copy link
Member

What type of PR is this?

Other

What does this PR do? Why is it needed?

This flag is useful for local testing and security analysis, but this flag should not be used in production!

Which issues(s) does this PR fix?

Other notes for review

@prestonvanloon prestonvanloon marked this pull request as ready for review May 11, 2023 15:55
@prestonvanloon prestonvanloon requested a review from a team as a code owner May 11, 2023 15:55
saolyn
saolyn approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@saolyn saolyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

config/features/flags.go
@@ -45,6 +45,10 @@ var (
Name: "disable-reorg-late-blocks",
Usage: "Disables reorgs of late blocks",
}
disablePeerScorer = &cli.BoolFlag{
Name: "disable-peer-scorer",
Usage: "(Danger): Disables P2P peer scorer. Do NOT use this in production!",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition of a use warning!

@prylabs-bulldozer prylabs-bulldozer bot merged commit cfa64ae into develop May 23, 2023
@prylabs-bulldozer prylabs-bulldozer bot deleted the revert-12138 branch May 23, 2023 13:53
james-prysm pushed a commit that referenced this pull request May 23, 2023
@prestonvanloon @james-prysm
Restore disable-peer-scorer flag (#12386)
ed992d9 
* Revert "Make Peer Scorer Permanent Default (#12138)"

This reverts commit 4d28d69.

* make peer scoring flag warning scary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saolyn saolyn saolyn approved these changes

@terencechain terencechain Awaiting requested review from terencechain terencechain is a code owner automatically assigned from prysmaticlabs/core-team

@rkapka rkapka Awaiting requested review from rkapka rkapka is a code owner automatically assigned from prysmaticlabs/core-team

@nisdas nisdas Awaiting requested review from nisdas nisdas is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prestonvanloon @saolyn