Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics: Invert too late and too early att received count #12392

Merged
merged 2 commits into from
May 12, 2023
Merged

Metrics: Invert too late and too early att received count #12392

merged 2 commits into from
May 12, 2023

Conversation

terencechain
Copy link
Member

If the attestation time is received before lower bound, it should be too late
If the attestation time is received after upper bound, it should be too early
This was flipped

@terencechain terencechain added Ready For Review A pull request ready for code review OK to merge labels May 12, 2023
@terencechain terencechain requested a review from a team as a code owner May 12, 2023 16:58
@terencechain terencechain self-assigned this May 12, 2023
@terencechain terencechain requested review from potuz, rkapka and nisdas May 12, 2023 16:58
@terencechain terencechain changed the title Invert too late and too early att received count Metrics: Invert too late and too early att received count May 12, 2023
@prylabs-bulldozer prylabs-bulldozer bot merged commit 9b13454 into develop May 12, 2023
@prylabs-bulldozer prylabs-bulldozer bot deleted the fix-att-recieved-metrics branch May 12, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-prysm james-prysm james-prysm approved these changes

@prestonvanloon prestonvanloon prestonvanloon approved these changes

@potuz potuz Awaiting requested review from potuz potuz is a code owner automatically assigned from prysmaticlabs/core-team

@rkapka rkapka Awaiting requested review from rkapka rkapka is a code owner automatically assigned from prysmaticlabs/core-team

@nisdas nisdas Awaiting requested review from nisdas nisdas is a code owner automatically assigned from prysmaticlabs/core-team

Assignees

@terencechain terencechain

Labels
Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@terencechain @prestonvanloon @james-prysm