Flip build-block-parallel feature flag
#12408
Conversation
| cfg.BuildBlockParallel = true | ||
| if ctx.IsSet(disableBuildBlockParallel.Name) { | ||
| logEnabled(disableBuildBlockParallel) | ||
| cfg.BuildBlockParallel = false |
There was a problem hiding this comment.
Could we not rename this to DisableBuildBlockParallel, that way it is false by default and then just set it to true if the flag disableBuildBlockParallel is set? Would also have to invert the condition where it is used in the code as well. But basically:
| cfg.BuildBlockParallel = true | |
| if ctx.IsSet(disableBuildBlockParallel.Name) { | |
| logEnabled(disableBuildBlockParallel) | |
| cfg.BuildBlockParallel = false | |
| if ctx.IsSet(disableBuildBlockParallel.Name) { | |
| logEnabled(disableBuildBlockParallel) | |
| cfg.DisableBuildBlockParallel = true |
It seems clearer than disableBuildBlockParallel setting BuildBlockParallel to false
There was a problem hiding this comment.
But then I will have to replace DisableBuildBlockParallel with BuildBlockParallel on the implementation side which is not ideal. I rather keep the changes constrained in the flag package to avoid core changes risk
There was a problem hiding this comment.
This has been the standard pattern: #9225
There was a problem hiding this comment.
Understood, thank you for clarifying!
…build-block-parallel
build-block-parallelis a great optimization for proposer, it has been tested on testnet over the last 2 weeks.The feature was enabled in v4.0.4 and we are planning to make it default for v4.0.5 with a disable option.