Copy All Field Tries For Late Blocks #12461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
reviewed
May 26, 2023
rkapka
approved these changes
May 26, 2023
nisdas
added
OK to merge
and removed
Blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Optimization
What does this PR do? Why is it needed?
In #10884, we added the ability for there to only be one relevant set of field tries held in memory. The main reason this was done was to not have Prysm store outdated field tries in memory as they took up a significant amount of space in the heap.
However doing this has brought some downsides in that older states will have to recompute all the tries for the fields in the event they are used to process a new block or are being used to advance slots. This causes issues when processing late blocks as you do end up having to regenerate the whole set of tries. To allow the next slot cache to function better, we add the ability to copy all tries for late blocks. This allows late blocks to be processed in an efficient manner along with keeping heap usage manageable.
Which issues(s) does this PR fix?
Fixes #12434
Other notes for review