Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GetBeaconBlock to use skip-mev-boost #12969

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Fix GetBeaconBlock to use skip-mev-boost #12969

merged 2 commits into from
Sep 29, 2023

Conversation

terencechain
Copy link
Member

@terencechain terencechain commented Sep 29, 2023

This PR fixes issue #12950 where GetBeaconBlock in the beacon API does not correctly utilize the skip-mev-boost parameter when making a call to the underlying prysm API.

Background:

In the beacon API, there are distinct endpoints for requesting a full block or a blind block. However, the prysm API does not make this distinction, instead relying on a skip-mev-boost parameter. The issue arises because the skip-mev-boost parameter was not being recognized or used within the GetBeaconBlock function in the beacon API. Here is the beacon API request:

v1alpha1req := &ethpbalpha.BlockRequest{
		Slot:         req.Slot,
		RandaoReveal: req.RandaoReveal,
		Graffiti:     req.Graffiti,
		SkipMevBoost: true, // Skip mev-boost and relayer network
	}

Changes:

This PR rectifies this oversight by incorporating the skip-mev-boost parameter. When this parameter is set to true, the payload construction for MEV Boost is skipped, effectively mimicking the behavior as if an override builder was applied from the engine API.

@terencechain terencechain added Bug Something isn't working Ready For Review A pull request ready for code review labels Sep 29, 2023
@terencechain terencechain requested a review from a team as a code owner September 29, 2023 01:31
@terencechain terencechain self-assigned this Sep 29, 2023
@nisdas nisdas merged commit 51b8075 into develop Sep 29, 2023
5 checks passed
@nisdas nisdas deleted the use-skip-mev-boost branch September 29, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants