Add context deadline for pending queue's receive block #13114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
changed the title
rkapka
reviewed
Oct 25, 2023
Comment on lines
211
to
212
| deadlineTime := time.Now().Add(twoSlotDuration) | ||
| contextWithDeadline, cancelFunction := context.WithDeadline(ctx, deadlineTime) |
There was a problem hiding this comment.
It is slightly less verbose to use a WithTimeout context
contextWithTimeout, cancelFunction := context.WithTimeout(ctx, twoSlotDuration)
8d41843 to
94a2a35
Compare
rkapka
approved these changes
Oct 25, 2023
terencechain
force-pushed
the
add-ctx-deadline
branch
from
94a2a35 to
62e45c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add context deadline for pending queue's receive block function. It's currently set to two slots