Late block: move checking of empty attribute earlier #13465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
force-pushed
the
move-attriute-earlier
branch
from
62c0a9d to
12a0888
Compare
terencechain
force-pushed
the
move-attriute-earlier
branch
from
12a0888 to
5f69850
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the happy case, validators will not propose the next block. In such scenarios, we will return early due to
attribute.IsEmpty()being true, eliminating the need to calls.headBlock()unless the validator is proposing the next slot. This approach avoids an unnecessary block copy.Note to the reviewer: Please exercise caution when reviewing any locking mechanisms in this PR, particularly the fork choice lock and head lock. It appears that
s.getPayloadAttributemay not require locking, but kindly verify this to ensure accuracy.