Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getLegacyDatabaseLocation: Change message. #13471

Merged
merged 2 commits into from
Jan 16, 2024
Merged

getLegacyDatabaseLocation: Change message. #13471

merged 2 commits into from
Jan 16, 2024

Conversation

nalepae
Copy link
Contributor

@nalepae nalepae commented Jan 16, 2024

What type of PR is this?
Other

What does this PR do? Why is it needed?
Some users complained on Discord that the message displayed when the validator client DB was found in the legacy
location was too scary.

This PR:

  • Changes this message from WARNING to INFO
  • Remove the "please move..." mention
  • Add more context

Example of message:

[2024-01-16 10:53:36]  INFO node: Database not found in the --datadir directory (/Users/manu/Library/Eth2)
		but found in the --wallet-dir directory (/Users/manu/Library/Eth2Validators/prysm-wallet-v2/direct),
		which was the legacy default.
		The next time you run the validator client without a database,
		it will be created into the --datadir directory (/Users/manu/Library/Eth2).
		To silence this message, you can move the database from (/Users/manu/Library/Eth2Validators/prysm-wallet-v2/direct/validator.db)
		to (/Users/manu/Library/Eth2/validator.db).

@nalepae nalepae requested a review from a team as a code owner January 16, 2024 09:52
validator/node/node.go Outdated Show resolved Hide resolved
Co-authored-by: Nishant Das <nishdas93@gmail.com>
@nisdas nisdas added this pull request to the merge queue Jan 16, 2024
Merged via the queue into develop with commit 46387a9 Jan 16, 2024
17 checks passed
@nisdas nisdas deleted the log-legacy-vc-dir branch January 16, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants